feat(kernel): expose reasoning trace on blocking InferenceResponse - #17
Open
amos-aios wants to merge 1 commit into
Open
feat(kernel): expose reasoning trace on blocking InferenceResponse#17amos-aios wants to merge 1 commit into
amos-aios wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InferenceResponse(the blocking-path result) had no field for a model'sdeep-reasoning trace, even though the streaming path surfaces one via
StreamChunk::Reasoning. Reasoning-capable models (DeepSeek-R1 style) losethat trace entirely for non-streaming callers.
This adds an optional, serde-defaulted
reasoning: Option<String>toInferenceResponse, mirroring the streaming representation:#[serde(default)]+ existing..Default::default()update syntax meanszero changes are required at any backend construction site.
skipped on serialize when
None.Motivation
Found while embedding the engine as an in-process library
(mofa-studio): the OpenAI-compatible gateway there forwards the blocking
reasoning_contentfield for R1-style traces and round-trips engineresponses through typed structs, so the missing field silently dropped the
trace. This restores parity between streaming and blocking paths.
Testing
cargo test -p mofa-kernel— 13 passed.cargo check/testgreen with the field added; no call-sitechurn anywhere.