-
Notifications
You must be signed in to change notification settings - Fork 370
Deduplicate common strings in translation #5085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deduplicate common strings in translation #5085
Conversation
1f877f8 to
114bc5d
Compare
|
Thanks for this PR, I will take a look shortly! 😄 |
|
This is a good start, don't forget to run |
|
These cases require separate strings for the Russian translation:
|
got it! will roll it back for now and file it under the same grammatical gender woes as the project visibility labels.
this one was an honest mistake, i wanted to keep it separate because it is a different context but i got distracted - thanks for catching that! |
This should lighten the cost of the i18n infra a little. Some notes apply:
commonMessages- some are to address existing duplicate use cases, while some simply contain common strings that could be reused elsewhere in the future (or are used in other places which aren't translatable at the moment).paymentMethodMessagesare now in thepayment-methodnamespace.paymentMethodCardDisplayhas also been moved fromcommonMessagestopaymentMethodMessages.common-messages.tsitself, particularly betweencommonMessagesandformFieldLabels, that this PR does not currently address.privateLabel,publicLabelandrejectedLabelare currently skipped, since they would need adjustment for grammatical gender in some languages. Ideally these should be split intoprojectandcollectionlabels at the very least; going deeper into project types would create a lot of duplication but technically be more proper for some languages... The same goes for the timestamps (updated/published/played/etc.).singleplayerLabel.