Skip to content

FIX-#7465: Properly implement Series.rename_axis#7466

Merged
sfc-gh-joshi merged 4 commits intomodin-project:mainfrom
sfc-gh-joshi:joshi/7465-series-rename_axis
Mar 20, 2025
Merged

FIX-#7465: Properly implement Series.rename_axis#7466
sfc-gh-joshi merged 4 commits intomodin-project:mainfrom
sfc-gh-joshi:joshi/7465-series-rename_axis

Conversation

@sfc-gh-joshi
Copy link
Contributor

What do these changes do?

Implements Series._set_axis_name to remove an AttributeError raised from Series.rename_axis.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Series.rename_axis raises AttributeError #7465
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

sfc-gh-joshi and others added 4 commits March 18, 2025 16:02
Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-joshi sfc-gh-joshi force-pushed the joshi/7465-series-rename_axis branch from 58e8c0b to 02b8734 Compare March 18, 2025 23:09
@sfc-gh-joshi sfc-gh-joshi enabled auto-merge (squash) March 18, 2025 23:54
@sfc-gh-joshi sfc-gh-joshi merged commit 97d8046 into modin-project:main Mar 20, 2025
41 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi/7465-series-rename_axis branch March 20, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Series.rename_axis raises AttributeError

3 participants