Initial prototype of telemetry hook#7443
Initial prototype of telemetry hook#7443sfc-gh-jkew wants to merge 1 commit intomodin-project:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "get_logger", | ||
| "enable_logging", | ||
| "disable_logging", | ||
| "emit_telemetry_event", |
Check failure
Code scanning / CodeQL
Explicit export is not defined Error
| "enable_logging", | ||
| "disable_logging", | ||
| "emit_telemetry_event", | ||
| "add_telemetry_handler", |
Check failure
Code scanning / CodeQL
Explicit export is not defined Error
| "disable_logging", | ||
| "emit_telemetry_event", | ||
| "add_telemetry_handler", | ||
| "clear_telemetry_handler" |
Check failure
Code scanning / CodeQL
Explicit export is not defined Error
| start_time = time.time() | ||
| try: | ||
| result = obj(*args, **kwargs) | ||
| emit_telemetry_event('', api_call_name, time.time() - start_time) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call Error
| # to collect discrete data on how modin is performing at the | ||
| # high level moden layer. | ||
| def emit_telemetry_event(msg:str, value:int|float): | ||
| _telemetry_handlers |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| try: | ||
| with timeout(seconds=1): | ||
| fn(f"modin::{msg}", value) | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
| except: | ||
| logging.ERROR("telemetry handler threw exception, removing handler: " + e) | ||
| _telemetry_handlers.remove(fn) | ||
| pass |
Check warning
Code scanning / CodeQL
Unnecessary pass Warning
| _telemetry_handlers.append(handler) | ||
|
|
||
| def clear_telemetry_handler(handler): | ||
| _telemetry_handlers = [] |
Check notice
Code scanning / CodeQL
Unused local variable Note
1 participant
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date