Skip to content

Add more maintainers to the PyPI metadata#1976

Merged
maxisbey merged 4 commits into
mainfrom
adding-more-maintainers
Feb 3, 2026
Merged

Add more maintainers to the PyPI metadata#1976
maxisbey merged 4 commits into
mainfrom
adding-more-maintainers

Conversation

@Kludex

@Kludex Kludex commented Jan 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@claude

claude Bot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Code review

Issue: Placeholder email addresses

Two of the new maintainer entries are using placeholder email addresses instead of real email addresses:

  • Line 12: { name = "Max Isbey", email = "add-yourself@gmail.com" }
  • Line 13: { name = "Felix Weinberger", email = "add-yourself@gmail.com" }

The email add-yourself@gmail.com is clearly a placeholder value that should be replaced with the actual email addresses for Max Isbey and Felix Weinberger before merging.

Why this matters:

  • This metadata will be published to PyPI
  • Both maintainers have the identical placeholder email, which is not legitimate
  • The existing maintainers all have proper, distinct email addresses
  • This creates confusion and makes it impossible to contact these maintainers

Suggested fix:
Max Isbey and Felix Weinberger should provide their actual email addresses to replace the placeholder values.

See the code here:

{ name = "Marcelo Trylesinski", email = "marcelotryle@gmail.com" },
{ name = "Max Isbey", email = "add-yourself@gmail.com" },
{ name = "Felix Weinberger", email = "add-yourself@gmail.com" }

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@Kludex

Kludex commented Feb 3, 2026

Copy link
Copy Markdown
Member Author

@maxisbey @felixweinberger please confirm with @dsp-ant we can merge this

@maxisbey

maxisbey commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

@maxisbey @felixweinberger please confirm with @dsp-ant we can merge this

oh yep will do

@maxisbey maxisbey merged commit 74f41ff into main Feb 3, 2026
31 checks passed
@maxisbey maxisbey deleted the adding-more-maintainers branch February 3, 2026 16:20
@maxisbey

maxisbey commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

@dsp-ant is happy yes

@dsp-ant

dsp-ant commented Feb 3, 2026

Copy link
Copy Markdown
Member
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants