feat(ci): Add check to ensure go fmt has been ran#43
Merged
findleyr merged 2 commits intomodelcontextprotocol:mainfrom Jun 25, 2025
Merged
feat(ci): Add check to ensure go fmt has been ran#43findleyr merged 2 commits intomodelcontextprotocol:mainfrom
go fmt has been ran#43findleyr merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
go fmt check to CI workflow
go fmt check to CI workflowgo fmt has been ran
Contributor
|
Thanks! We're actually pretty naive to GitHub actions (we have our own CI system for the Go project). Much appreciated. |
findleyr
approved these changes
Jun 25, 2025
Contributor
Author
|
I've done a ton with GHA over the years, happy to help add anything y'all find useful (e.g. golangci-lint setup). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I noticed that some of the files weren't formatted (
go fmtleft dirty files onmain), so I went ahead and added alintCI job. We can add more linting things later if folks want, but validating formatting seemed like a nice first step.I pushed a separate commit with
go fmt ./...ran alone (just to make it clear what was automated changes vs manual ones).How Has This Been Tested?
N/A
Breaking Changes
N/A
Types of changes
Checklist
Additional context