fix consolidate training run outputs into a single runs/ directory#580
fix consolidate training run outputs into a single runs/ directory#580sudhansu-24 wants to merge 1 commit intomllam:mainfrom
Conversation
|
thanks @sadamov for clarifying. I’ll continue implementation/revisions on #580 and coordinate here. |
|
Thanks @sudhansu-24 for taking this forward! From my side, I’ve aligned all training artifacts so they are now scoped under I also updated the logger setup so that both WandbLogger and CustomMLFlowLogger use the same Currently, only one logger is active at a time (default is W&B), and MLflow artifacts are generated when explicitly running with If there are any preferences around structure or logging behavior from earlier work, I’m happy to incorporate them. Let me know if you’d like me to push any additional changes to the PR. |
|
Thanks @Shyam-Sunder-saini could you share the exact changes you want added beyond the current #580 state (especially around the a short checklist by file, or a commit/PR branch we can cherry-pick from? if you post that i will incorporate it quickly so we can finalize review. |
cd1a3ef to
dd2a1a2
Compare
Describe your changes
Training and evaluation artifacts are written under a single directory
runs/<run-name>/:ModelCheckpointusesruns/<run-name>/checkpoints/,Trainer(default_root_dir=...)keeps Lightning CSV logs under that run instead of a top-levellightning_logs/, andWandbLogger/CustomMLFlowLoggerusesave_dir=run_dirso internal logger paths and code usingself.logger.save_dir(e.g. plots) stay under the run root. Checkpoints remain outside W&B’swandb/subtree so large files are not synced by default.Motivation: Issue #293 and maintainer feedback (W&B selective sync, common run root, MLflow temp images not in CWD).
Dependencies: None
Issue Link
closes #293
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee