FEMTree: throw rather than hard-exit for invalid faces#220
Open
nigels-com wants to merge 1 commit intomkazhdan:masterfrom
Open
FEMTree: throw rather than hard-exit for invalid faces#220nigels-com wants to merge 1 commit intomkazhdan:masterfrom
nigels-com wants to merge 1 commit intomkazhdan:masterfrom
Conversation
Author
|
This handling appears to have moved to Src/FEMTree.LevelSet.3D.inl |
nigels-com
force-pushed
the
throw-upstream
branch
from
2d16db8 to
d0c57b2
Compare
Author
|
This PR has been updated according to the current master branch of PoissonRecon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via Open3D repo PR #1
We have some corner cases that causes Poisson surface reconstruction to fail.
However we would rather throw (and catch and handle) exceptions, rather than terminate the broader application.