Add state validation to QuantumDevice.set_states()#324
Open
yurekami wants to merge 1 commit intomit-han-lab:mainfrom
Open
Add state validation to QuantumDevice.set_states()#324yurekami wants to merge 1 commit intomit-han-lab:mainfrom
yurekami wants to merge 1 commit intomit-han-lab:mainfrom
Conversation
Add optional check_legality parameter to set_states() that warns when: - Input batch size differs from device's bsz (and updates bsz) - States are not properly normalized (|amplitudes|^2 should sum to 1) This helps users catch common mistakes like: - Passing more states than expected batch size - Using unnormalized states for quantum computations The validation is opt-in (check_legality=False by default) to maintain backwards compatibility and avoid performance overhead. Fixes mit-han-lab#305 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
check_legalityparameter toset_states()that validates:Problem
As noted in #305, users can set states with mismatched batch sizes or unnormalized states without any warning, leading to confusion and incorrect results.
Solution
Add opt-in validation with informative warnings:
The device's
bszis updated to match the input states' batch size.Test plan
Fixes #305
🤖 Generated with Claude Code