Skip to content

fix(backend): プロキシアカウントからのフォローリクエストがある場合は再度送信しないように#17242

Open
kakkokari-gtyih wants to merge 3 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-16001
Open

fix(backend): プロキシアカウントからのフォローリクエストがある場合は再度送信しないように#17242
kakkokari-gtyih wants to merge 3 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-16001

Conversation

@kakkokari-gtyih
Copy link
Contributor

What

Why

Fix #16001

Additional info (optional)

あってるか不明

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 15, 2026
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Mar 15, 2026
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.56%. Comparing base (a3b0dc9) to head (ee04d84).

Files with missing lines Patch % Lines
packages/backend/src/core/UserFollowingService.ts 13.33% 13 Missing ⚠️
packages/backend/src/core/QueueService.ts 50.00% 1 Missing ⚠️
packages/backend/src/core/UserListService.ts 0.00% 1 Missing ⚠️
packages/backend/src/queue/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17242      +/-   ##
===========================================
+ Coverage    63.54%   63.56%   +0.01%     
===========================================
  Files         1161     1161              
  Lines       116244   116259      +15     
  Branches      8360     8365       +5     
===========================================
+ Hits         73871    73895      +24     
+ Misses       40188    40160      -28     
- Partials      2185     2204      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 315.96 MB 315.27 MB -0.68 MB -0.21%
VmHWM 315.96 MB 315.27 MB -0.68 MB -0.21%
VmSize 23110.05 MB 23109.58 MB -0.46 MB 0%
VmData 1379.85 MB 1379.78 MB -0.07 MB 0%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 315.96 MB 315.27 MB -0.68 MB -0.21%
VmHWM 315.96 MB 315.27 MB -0.68 MB -0.21%
VmSize 23110.05 MB 23109.58 MB -0.46 MB 0%
VmData 1379.85 MB 1379.78 MB -0.07 MB 0%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 316.37 MB 315.62 MB -0.74 MB -0.23%
VmHWM 316.37 MB 315.62 MB -0.74 MB -0.23%
VmSize 23110.05 MB 23109.58 MB -0.46 MB 0%
VmData 1379.85 MB 1379.78 MB -0.07 MB 0%

See workflow logs for details

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo
Copy link
Member

syuilo commented Mar 18, 2026

フォローリクエストがある状態かどうかというのはローカルのDBを見るだけでは判断できないと思うから、どっちかというと受け取り側で重複したフォローリクエストを弾くようにした方が良い気がするわね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

複数のリストに追加された場合に、proxyアカウントからのフォローリクエストが複数回発行される

2 participants