You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This RFC defines a system for grin wallet to support multiple wallets in the root wallet directory. The basis of the document text is an old closed PR by @yeastplume with some extra definition added to modernize the proposal to the current wallet Owner API.
This overlaps with some ideas from @davidtavarez. The funding request was cancelled because the timing was not right, but there is a widespread support for this idea and as such possibility for funding can be discussed 😀
I checked the RFC, looks good to me. And yes, I think the benefits of having this option outweighs the downside of having added complexity.
Would be nice to combine your work directly with additional implementation of one-time use adressess and multiple accounts, but could also be separate since having multi-wallet support is a good step forward anyhow.
Just a thought, would it be better to have a global grin-server.toml file as well as a local grin-server.toml per wallet where users can have separate settings? I have not plaid around much with grin-walllet so this is an open question that might be better answered by those who want to use multiple wallets for various reasons, e.g. exchanges.
Also, we might need to have such a local grin-server.toml file if we want to implement one-time use addresses. We might want to store settings and configurations for having multiple accounts and settings per account in it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RFC defines a system for grin wallet to support multiple wallets in the root wallet directory. The basis of the document text is an old closed PR by @yeastplume with some extra definition added to modernize the proposal to the current wallet Owner API.
Rendered Text
Any and all feedback appreciated.