Issue 403 Support for UPPER/LOWER (and other data provider functions)#454
Open
Jabestrada wants to merge 2 commits intomikependon:masterfrom
Open
Issue 403 Support for UPPER/LOWER (and other data provider functions)#454Jabestrada wants to merge 2 commits intomikependon:masterfrom
Jabestrada wants to merge 2 commits intomikependon:masterfrom
Conversation
…such as, but not limited to, UPPER() and LOWER().
Owner
|
@Jabestrada - you made a very big PR, thank you for this. I would like to test it locally, can you create a branch and put all of the code on that branch so I can test it locally prior merging it? I will add you as collaborator now so you can do push to that branch. |
Owner
|
@Jabestrada - no need to create a branch, but instead I will clone yours for local testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for proposed implementation of feature to support data provider functions such as (but not limited to) UPPER/LOWER #403
Caveat: I left out some housekeeping concerns (dependency injection, file locations, unit test coverage, etc.) pending confirmation that the proposed approach is the way to go.