Plane splitPolygon running into loop / StackOverflowError#53
Open
udatny wants to merge 7 commits intomiho:masterfrom
Open
Plane splitPolygon running into loop / StackOverflowError#53udatny wants to merge 7 commits intomiho:masterfrom
udatny wants to merge 7 commits intomiho:masterfrom
Conversation
we're adjusting two things... still the root cause of the stackoverflow is still not clear. we're using a random polygon to define the plane for the node. chances are bigger that find a a coplanar polygon. then if we have only one polygon as an input, we're expecting it to be coplanar. a better alternative may be to say that as long as the polygon from which we defined the plane is not SPANNING, it must be COPLANAR. anyway, this fix made my situation work again. maybe the issues arise from bigger models somewhere in the 100 dimension
for maven-based builds
this is a quick and dirty fix which does the job.
run this test to reproduce the StackOverflowError
|
I have a StackOverflowError when performing the intersect method on two objects. In addition, it produces many lines of "our plane is not spanning and not coplannar but it should be 1.0" Any ideas? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i runned several times into the stackoverflow issue (which also people reported #48 ) and i am still not sure what it is causing. fact is, that under certain circumstances the Plane.splitPolygon could end in a loop. somehow it does not recognize polygons as coplanar.
it is reproducable with the AppleTest i added. (simply run mvn test -Dtest=eu.mihosoft.jcsg.AppleTest
in the root folder)
a possible fix is also there but in my opinion it is not addressing the root cause....it just works around the issue.
maybe you find time to analyze.