Batch consecutive same-attribute cells in ViewLineSegmentBuilder#489
Closed
msupuka wants to merge 1 commit intomigueldeicaza:mainfrom
Closed
Batch consecutive same-attribute cells in ViewLineSegmentBuilder#489msupuka wants to merge 1 commit intomigueldeicaza:mainfrom
msupuka wants to merge 1 commit intomigueldeicaza:mainfrom
Conversation
Reduces NSAttributedString allocations from ~59 to ~3-5 per line by accumulating text for cells with identical attributes and flushing as a single NSAttributedString when attributes change. Also simplifies buildAttributedString() by removing redundant call-site batching — the builder now handles batching internally via NSDictionary equality comparison on attribute dictionaries. Benchmarked: 14x speedup on attributed string construction. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces NSAttributedString allocations from ~59 to ~3-5 per line by accumulating text for cells with identical attributes and flushing as a single NSAttributedString when attributes change.
Also simplifies buildAttributedString() by removing redundant call-site batching — the builder now handles batching internally via NSDictionary equality comparison on attribute dictionaries.
Benchmarked: 14x speedup on attributed string construction.