Make cellDimension, CellDimension, and BufferLine.isWrapped public#475
Open
MehdiG44 wants to merge 1 commit intomigueldeicaza:mainfrom
Open
Make cellDimension, CellDimension, and BufferLine.isWrapped public#475MehdiG44 wants to merge 1 commit intomigueldeicaza:mainfrom
MehdiG44 wants to merge 1 commit intomigueldeicaza:mainfrom
Conversation
… public These properties are needed by consumers for: - cellDimension: Converting tap coordinates to terminal row/column - isWrapped: Detecting soft-wrapped lines for URL detection across line breaks Co-Authored-By: Claude Opus 4.6 <[email protected]>
Owner
|
I have been working on proper URL handling, both auto-detected and properly annotated URLs. Would you mind checking my branch The reason is that once these things become public, they limit what I can do internally without breaking people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes three properties public so embedding apps can implement tap-to-open-URL and other position-aware features:
TerminalView.cellDimension(iOSTerminalView.swift) — needed to convert tap coordinates to terminal rows/columnsCellDimensiontypealias (AppleTerminalView.swift) — required becausecellDimension's type must also be publicBufferLine.isWrapped(BufferLine.swift) — needed to distinguish soft-wrapped lines from hard newlinesMotivation
Terminal apps commonly need to detect URLs under a user's tap. This requires:
cellDimension)isWrapped)These are read-only access patterns — no behavior changes, no API surface increase beyond visibility.
Changes
Three
internal→publicvisibility changes. No logic changes, no new API.