[1.29] Fix crash with --disable-interactivity and EFResume#6303
Draft
Trenly wants to merge 1 commit into
Draft
Conversation
Trenly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
When
winget install --disable-interactivityis executed with the Resume experimental feature enabled, checkpoint creation saves all command-line arguments. On resume or during checkpoint validation, the code callsArgument::ForType()on every saved argument type to reconstruct the execution context. However,Execution::Args::Type::DisableInteractivitywas missing from theArgument::ForType()switch statement, causing the default case to throwE_UNEXPECTED (0x8000ffff)instead of properly handling the flag.🔗 References
🔍 Validation
✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow