agent sessions - fix chat title sidebar action visibility - #283338
Merged
Conversation
Benjamin Pasero (bpasero)
enabled auto-merge (squash)
December 13, 2025 15:06
Copilot started reviewing on behalf of
Benjamin Pasero (bpasero)
December 13, 2025 15:07
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the visibility of the "Show Agent Sessions" action in the chat title sidebar toolbar by introducing a new context key agentSessionsViewerVisible that tracks whether the agent sessions viewer is currently visible. The action should be shown when the viewer is either hidden or in stacked orientation.
Key Changes
- Adds a new
agentSessionsViewerVisiblecontext key to track agent sessions viewer visibility state - Updates the menu conditions for the chat view session title toolbar to show the "Show Agent Sessions" button when the viewer is not visible OR when it's in stacked orientation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatContextKeys.ts | Defines new agentSessionsViewerVisible context key |
| src/vs/workbench/contrib/chat/browser/chatViewPane.ts | Binds the new context key and updates it when sessions container visibility changes |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.contribution.ts | Updates menu item conditions to check visibility state using the new context key |
Daniel Imms (Tyriar)
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.