Skip to content

[http specs] Add new test case for multipart#9139

Merged
msyyc merged 12 commits intomainfrom
http-specs-multipart-renaming-case
Jan 6, 2026
Merged

[http specs] Add new test case for multipart#9139
msyyc merged 12 commits intomainfrom
http-specs-multipart-renaming-case

Conversation

@msyyc
Copy link
Copy Markdown
Contributor

@msyyc msyyc commented Dec 4, 2025 •
edited
Loading

Add test case to cover scenarios of #9137 and #9136

This PR adds 2 cases:

  • set different wire name for http part
  • make file part optional

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 4, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http@9139

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client@9139

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client-js@9139

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-specs@9139

commit: 80cd427

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http-client-js
  • ✅ @typespec/http-specs
Show changes

@typespec/http-specs - feature ✏️

Add new test case for multipart

@typespec/http-client-js - internal ✏️

skip multipart test case until bug is fixed to unblock new spector case merge

@msyyc msyyc mentioned this pull request Dec 4, 2025
Merged
1 task
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Dec 4, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@msyyc msyyc marked this pull request as ready for review December 5, 2025 05:29
@msyyc
Copy link
Copy Markdown
Contributor Author

msyyc commented Dec 5, 2025 •
edited
Loading

The CI failure seems related with http-client-js which can't handle the new test case:

image CC. @MaryGao

@msyyc msyyc mentioned this pull request Dec 5, 2025
Merged
1 task
@msyyc msyyc added the lib:http-specs For issues/prs related to the @typespec/http-specs package label Dec 5, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
@msyyc
[Python] Fix serialization name for multipart (#9138)
7af8f6d 
fix #9137

Related PR: 
- [ ] #9139
@MaryGao
Copy link
Copy Markdown
Member

MaryGao commented Dec 8, 2025 •
edited
Loading

The CI failure seems related with http-client-js which can't handle the new test case:

image CC. @MaryGao

@msyyc there are some generation issues for new cases. Could you help add them into ignore file? https://github.com/microsoft/typespec/blob/main/packages/http-client-js/.testignore

github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
@msyyc
[Python] Fix multipart when files part is optional (#9144)
27036b8 
fix #9136

Related PR:
- [ ] #9139
@msyyc msyyc mentioned this pull request Dec 8, 2025
Open
@msyyc msyyc mentioned this pull request Dec 12, 2025
Closed
14 tasks
MaryGao
MaryGao reviewed Dec 17, 2025
View reviewed changes
weidongxu-microsoft
weidongxu-microsoft approved these changes Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msyyc msyyc enabled auto-merge December 19, 2025 04:22
@msyyc msyyc disabled auto-merge December 19, 2025 04:22
@msyyc
Copy link
Copy Markdown
Contributor Author

msyyc commented Dec 19, 2025

@timotheeguerin pls help review this PR, thanks!

@msyyc msyyc enabled auto-merge December 19, 2025 04:23
@msyyc msyyc added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 86cedf9 Jan 6, 2026
27 checks passed
@msyyc msyyc deleted the http-specs-multipart-renaming-case branch January 6, 2026 19:23
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:js Issue for the JS client emitter: @typespec/http-client-js label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaryGao MaryGao MaryGao approved these changes

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@timovv timovv Awaiting requested review from timovv timovv is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

Assignees

No one assigned

Labels

emitter:client:js Issue for the JS client emitter: @typespec/http-client-js lib:http-specs For issues/prs related to the @typespec/http-specs package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@msyyc @azure-sdk @MaryGao @timotheeguerin @weidongxu-microsoft