Fix font face keyboard selection crash#20255
Merged
carlos-zamora merged 1 commit intoJun 22, 2026
Merged
Conversation
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlos-zamora
approved these changes
Jun 22, 2026
carlos-zamora
left a comment
carlos-zamora
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay. Tested this myself. This does fix the crash. Thank you so much for doing this!
This does unveil a new bug: #20353
But that bug definitely existed beforehand, it was just inaccessible (or more rare) due to the crash.
I'm fine with that for now. The bug is avoided if the user is using a mouse to move around.
Contributor
Author
|
@carlos-zamora No problem 🙂, I will check the issue #20353 and get back to you. |
carlos-zamora
pushed a commit
that referenced
this pull request
Jun 30, 2026
## Summary Fixes the font face `AutoSuggestBox` resetting to its previous value, or stale filter text, after a keyboard-selected font is committed and focus later leaves the control. WinUI restores its cached user query when the suggestion list closes. The existing `LostFocus` path then treated that programmatic restoration as fresh user input and committed the stale value. This change distinguishes genuine user edits from programmatic text restoration, preserving the committed font value while retaining the queued selected-suggestion commit introduced by #20255. Fixes #20353. ## Validation Manually validated with a local `CascadiaPackage` Debug x64 build: - Reproduced the reset before the fix. - Selected `Lucida Console` from `Consolas` using keyboard navigation. - Pressed Enter and confirmed `Lucida Console` was applied. - Returned focus to the Font face control and tabbed out again. - Verified `Lucida Console` remained selected. - Verified stale filter text did not return. - Verified the #20245 crash did not regress. - Verified Save and Discard changes both work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in the Settings UI font face control when selecting a font suggestion with the keyboard and pressing Enter.
The font face
AutoSuggestBoxpath was explicitly unfocusing the box after a chosen suggestion was submitted. During the keyboard suggestion commit path, thatFocus(FocusState::Unfocused)call can trigger a WinUI/XAML crash before the settings model update completes.This change avoids explicitly unfocusing the
AutoSuggestBoxin the chosen-suggestion path and instead commits the selected font and moves focus to the parent container.Fixes #20245.
Validation
Manually validated with a local
CascadiaPackageDebug x64 build: