Make Secondary Allocator a template parameter - #774
Merged
Conversation
Matthew Parkinson (mjp41)
force-pushed
the
secondary
branch
from
June 27, 2025 16:00
f25a2e6 to
8b5f020
Compare
Matthew Parkinson (mjp41)
requested a review
from Schrodinger ZHU Yifan (SchrodingerZhu)
June 30, 2025 10:58
Matthew Parkinson (mjp41)
force-pushed
the
secondary
branch
from
June 30, 2025 13:02
8b5f020 to
ed863db
Compare
This refactors the use of the Secondary Allocator, so that out of tree implementations can be used.
Matthew Parkinson (mjp41)
force-pushed
the
secondary
branch
from
June 30, 2025 13:16
ed863db to
0a3ea0d
Compare
Schrodinger ZHU Yifan (SchrodingerZhu)
approved these changes
Jun 30, 2025
Schrodinger ZHU Yifan (SchrodingerZhu)
left a comment
Schrodinger ZHU Yifan (SchrodingerZhu)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Matthew Parkinson (mjp41)
merged commit Jun 30, 2025
9a3d12a
into
microsoft:main
171 of 173 checks passed
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the use of the Secondary Allocator, so that out of tree implementations can be used.