Fix snapshot/renderblocks for disabled blocks#11272
Open
microbit-matt-hillsdon wants to merge 1 commit intomicrosoft:masterfrom
Open
Fix snapshot/renderblocks for disabled blocks#11272microbit-matt-hillsdon wants to merge 1 commit intomicrosoft:masterfrom
microbit-matt-hillsdon wants to merge 1 commit intomicrosoft:masterfrom
Conversation
They're missing the CSS variables introduced in Blockly 12 and so get the background of the block wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They're missing the CSS variable introduced in Blockly 12 and so get the background of the block wrong.
This affects renderblocks and right-click "Snapshot".
It's a bit awkward to handle both in the SVG DOM case (where we can add it to the style attribute) and the serialized case where we want to move it to the new style tag. Other suggestions very welcome.
Before
(ignore the line at the bottom, that's my poor cropping skills)
After