fix: Resolve tool_call ACE + prompt injection from chat history#4015
Merged
fix: Resolve tool_call ACE + prompt injection from chat history#4015
Conversation
promptflow-evals test result 9 files ± 0 9 suites ±0 59m 24s ⏱️ + 44m 59s Results for commit d8a3f7f. ± Comparison against base commit 6b38d80. This pull request removes 125 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Improve legibility of escaper utils
This notably fixes an issue where the chat history is not escaped
0884335 to
d8a3f7f
Compare
needuv
approved these changes
Jun 4, 2025
w-javed
approved these changes
Jun 4, 2025
jiazengcindy
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves 2 security issues:
evalwithast.literal_evalRelated to ICM 31000000356466
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines