Skip to content

consomme: update smoltcp to 0.12.0#2733

Merged
damanm24 merged 5 commits intomicrosoft:mainfrom
damanm24:update-smoltcp
Feb 4, 2026
Merged

consomme: update smoltcp to 0.12.0#2733
damanm24 merged 5 commits intomicrosoft:mainfrom
damanm24:update-smoltcp

Conversation

@damanm24
Copy link
Contributor

@damanm24 damanm24 commented Feb 4, 2026

The following PRs: #2633 and #2398 require features that are only available in a newer version of smoltcp. Since the linked PRs are already large in size, it makes sense to do the version upgrade and corresponding build fixes in a separate PR. Unfortunately, there have been some changes in smoltcp that add bloat to our dependency list. Despite trying a myriad of combinations to turn off various features, I wasn't able to reduce the number of requisite dependencies that we have to pull in as a result of doing this upgrade.

@damanm24 damanm24 requested a review from a team as a code owner February 4, 2026 01:00
Copilot AI review requested due to automatic review settings February 4, 2026 01:00
@damanm24 damanm24 requested a review from a team as a code owner February 4, 2026 01:00
jstarks
jstarks previously approved these changes Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added the unsafe Related to unsafe code label Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

⚠️ Unsafe Code Detected

This PR modifies files containing unsafe Rust code. Extra scrutiny is required during review.

For more on why we check whole files, instead of just diffs, check out the Rustonomicon

jstarks
jstarks previously approved these changes Feb 4, 2026
@damanm24 damanm24 merged commit 084a1bf into microsoft:main Feb 4, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unsafe Related to unsafe code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants