Conversation
|
@dependabot recreate |
Removes [@tootallnate/once](https://github.com/TooTallNate/once). It's no longer used after updating ancestor dependency [jsdom](https://github.com/jsdom/jsdom). These dependencies need to be updated together. Removes `@tootallnate/once` Updates `jsdom` from 19.0.0 to 28.1.0 - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md) - [Commits](jsdom/jsdom@19.0.0...28.1.0) --- updated-dependencies: - dependency-name: "@tootallnate/once" dependency-version: dependency-type: indirect - dependency-name: jsdom dependency-version: 28.1.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
a2c9d7d to
0c3dbd5
Compare
|
@copilot Investigate broken build due to jsdom major version bump. |
- Create test/test-setup.mjs as an ES module to support jsdom 22+ (ESM-only)
- Use import { JSDOM } from 'jsdom' instead of require('jsdom')
- Use createRequire to register CSS extension handler (needed for monaco-editor-core CSS imports)
- Use Object.defineProperty for navigator (read-only property in ESM module context)
- Update test:grammars script to use --import ./test/test-setup.mjs instead of --require ./test/test-setup.js
Agent-Logs-Url: https://github.com/microsoft/monaco-editor/sessions/b539df67-cb91-473b-88f4-caa2f9ad207d
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
The build was failing because jsdom 22+ is ESM-only, but Fixed in 410dc81 by:
All 86 grammar tests pass locally. |
|
@copilot What happens to test-setup.js? Can it be deleted? |
Agent-Logs-Url: https://github.com/microsoft/monaco-editor/sessions/16b9e5be-7967-42f2-8580-d0426a59173e Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
|
@copilot Reapply changes to resolve merge conflicts |
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Done in 7d82d07. Merged |
Removes @tootallnate/once. It's no longer used after updating ancestor dependency jsdom. These dependencies need to be updated together.
Removes
@tootallnate/onceUpdates
jsdomfrom 19.0.0 to 28.1.0Release notes
Sourced from jsdom's releases.
... (truncated)
Changelog
Sourced from jsdom's changelog.
... (truncated)
Commits
12949b5Version 28.1.0ce4c58fApply CSS specificity when computing styles7ed55a0Skip single-byte-decoder encoding tests on Node 20f3b1973Generalize node version conditions in test expectations853c596Rewrite getElementById ID caching for tree-order correctness5fbfde6Fix potential sync XHR worker hang from unhandled dispatch errors82df38fCache the root node for document-connected treesed7c5c0Add documentation comment to create-event-accessor.jsb4562e9Simplify Window.js installEventHandlers7da340fCentralize "determine the target of an event handler"Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.