Skip to content

Add support for multiple apk architectures + upload mapping #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyguy321 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for multiple apk architectures + upload mapping #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca52c2a
Update main.ts
wyguy321 Jan 13, 2023
164eae4
Update inputsHelper.ts
wyguy321 Jan 13, 2023
a5cc3f3
Update main.ts
wyguy321 Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions Tasks/GooglePlayReleaseV4/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ async function run(): Promise<void> {
const userFractionSupplied: boolean = tl.getBoolInput('rolloutToUserFraction');
const userFraction: number = Number(userFractionSupplied ? tl.getInput('userFraction', false) : 1.0);

const uploadMappingFile: boolean = tl.getBoolInput('shouldUploadMappingFile', false) && (action === 'SingleApk' || action === 'SingleBundle');
const uploadMappingFile: boolean = tl.getBoolInput('shouldUploadMappingFile', false) && (action === 'SingleApk' || action === 'SingleBundle' || action === 'MultiApk');
const mappingFilePattern: string = tl.getInput('mappingFilePath');

const uploadNativeDebugSymbols: boolean = tl.getBoolInput('shouldUploadNativeDebugSymbols', false) && (action === 'SingleApk' || action === 'SingleBundle');
Expand Down Expand Up @@ -160,15 +160,21 @@ async function run(): Promise<void> {
}

if (uploadMappingFile) {
tl.debug(`Mapping file pattern: ${mappingFilePattern}`);

const mappingFilePath = fileHelper.resolveGlobPath(mappingFilePattern);

for (const versionCode of versionCodes) {

const mappingFilePath = fileHelper.resolveGlobPath(mappingFilePattern);
tl.checkPath(mappingFilePath, 'Mapping file path');

console.log(tl.loc('FoundDeobfuscationFile', mappingFilePath));
tl.debug(`Uploading ${mappingFilePath} for version code ${versionCodes[0]}`);
await googleutil.uploadDeobfuscation(edits, mappingFilePath, packageName, versionCodes[0]);
}
tl.debug(`Uploading ${mappingFilePath} for version code ${versionCode]}`);
await googleutil.uploadDeobfuscation(edits, mappingFilePath, packageName, versionCode);


}


}

if (uploadNativeDebugSymbols) {
tl.debug(`Native debug symbols file pattern: ${nativeDebugSymbolsFilePattern}`);
Expand Down
2 changes: 1 addition & 1 deletion Tasks/GooglePlayReleaseV4/modules/inputsHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function getClientKey(): googleutil.ClientKey {
return key;
}

const actions = ['OnlyStoreListing', 'SingleBundle', 'SingleApk', 'MultiApkAab'] as const;
const actions = ['OnlyStoreListing', 'SingleBundle', 'SingleApk', 'MultiApkAab',"MultiApk"] as const;
export type Action = (typeof actions)[number];

/**
Expand Down