Create python-package-conda.yml #1080
Conversation
|
👋 Thanks for contributing @bensonsandallofusllc-png! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
This PR adds a GitHub Actions workflow for building and testing Python packages using Conda. The workflow is triggered on every push and includes steps for setting up the Python environment, linting with flake8, and running tests with pytest.
Changes:
- Add a new GitHub Actions workflow file that uses Conda for Python package management and testing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Test with pytest | ||
| run: | | ||
| conda install pytest | ||
| pytest |
There was a problem hiding this comment.
This workflow runs pytest but there are no test files in the repository. The pytest command will fail or pass without testing anything. Either add test files or remove this step from the workflow.
| - name: Test with pytest | |
| run: | | |
| conda install pytest | |
| pytest |
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Python 3.10 | ||
| uses: actions/setup-python@v3 |
There was a problem hiding this comment.
The actions/setup-python action is using v3 which is outdated. Other workflows in this repository use actions/checkout@v5, so for consistency and to get the latest features and security updates, this should be updated to v5.
| uses: actions/setup-python@v3 | |
| uses: actions/setup-python@v5 |
| max-parallel: 5 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
The actions/checkout action is using v4 while other workflows in this repository use v5. For consistency and to ensure the latest features and security updates, this should be updated to v5.
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v5 |
| echo $CONDA/bin >> $GITHUB_PATH | ||
| - name: Install dependencies | ||
| run: | | ||
| conda env update --file environment.yml --name base |
There was a problem hiding this comment.
This workflow references environment.yml but this file doesn't exist in the repository. The workflow will fail when it attempts to execute this command. Either create an environment.yml file or update this step to use the existing requirements.txt file instead.
| conda env update --file environment.yml --name base | |
| python -m pip install --upgrade pip | |
| python -m pip install -r requirements.txt |
|
@copilot open a new pull request to apply changes based on the comments in this thread |
2 participants
No description provided.