Skip to content

Observing iframe events in insights script #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malaref wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Observing iframe events in insights script #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/clarity-js/src/insight/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@ export function start(): void {
doc.start();
getId(document.documentElement); // Pre-discover ID for page root
interaction.observe(document);

// observe other document nodes
const iframes = document.querySelectorAll("iframe");
for (let i = 0; i < iframes.length; i++) {
const iframe = iframes[i];
if (iframe.contentDocument) {
Copy link
Copy Markdown
Collaborator

@nairmanu nairmanu Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can throw exception if iframe is cross origin so better to wrap it in try catch to avoid console errors

getId(iframe.contentDocument.documentElement); // Pre-discover ID for iframe root
Copy link
Copy Markdown
Collaborator

@nairmanu nairmanu May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to call getId?

interaction.observe(iframe.contentDocument);
}
}
}

export function stop(): void {
Expand Down