Audit cleanup: remove orphaned files, dead scripts, and stale references#2831
Open
CodingIsBliss wants to merge 3 commits intomainfrom
Open
Audit cleanup: remove orphaned files, dead scripts, and stale references#2831CodingIsBliss wants to merge 3 commits intomainfrom
CodingIsBliss wants to merge 3 commits intomainfrom
Conversation
added 3 commits
March 16, 2026 12:50
Audit findings:
- vsts/ folder: No ADO pipeline definitions point to GitHub Oryx's vsts/.
All active ADO pipelines run against the internal AAPT-Antares-Oryx repo
with OneBranch .pipelines/ YAML files. The entire vsts/ folder (66 files)
is orphaned legacy code from the pre-OneBranch era.
- build/buildBuildImageBases.sh: Zero pipeline or workflow callers. Only
referenced in (now-updated) documentation.
- build/buildBuildpacksImages.sh: Zero pipeline or workflow callers.
Note: the buildpack CLI code in src/ and images/pack-builder/ are kept
as they are part of the active product.
- .github/workflows/monitor-versions.yaml: Stub 'Hello World' placeholder
that was never implemented. The corresponding ADO pipeline
'Monitor-versions.yml' is also disabled (last run Oct 2024).
Fixes:
- Created build/generateConstants.sh which is referenced by the active
automationTemplate.yaml GH Actions workflow but was missing from the repo.
This script invokes SharedCodeGenerator to regenerate C#, Shell, and Go
constant files from build/constants.yaml.
- Updated Oryx.sln to remove vsts solution folder references.
- Updated doc/architecture.md, doc/base_images.md, build/Readme.md to
remove broken links and outdated vsts references.
- Fixed SharedCodeGenerator README path reference.
ADO pipeline status (AAPT-Antares-Oryx repo):
Active: Buddy, Official, Publish-Binaries-Buddy, Publish-To-Prod,
Publish-To-Stage, OryxTests
Disabled: Antares-Oryx-Release-Binaries, Monitor-versions.yml,
PRValidator (in \delete folder)
Root-level removals: - CodeMaid.config: VS extension preference from 2019, no CI usage - Detector.sln: Redundant (Oryx.sln already contains all its projects) - CHANGELOG.md: Empty placeholder since 2019, never populated Build script removals (all were only called from the deleted vsts/ pipelines): - build/buildSln.sh: Trivial wrapper, unit-tests.yaml uses dotnet directly - build/buildTestBuildImages.sh: Test image builder, no GH Actions caller - build/testBuildScriptGenerator.sh: unit-tests.yaml handles this - build/testIntegration.sh: ADO internal pipelines handle integration tests - build/buildPlatformBinaries.sh: Zero references after vsts/ removal - build/release.txt: Empty placeholder since 2019 Generated constant files with zero consumers: - build/__dotNetCoreRunTimeVersions.sh: No file sources this - build/__dotNetCoreSdkVersions.sh: No file sources this - build/__phpVersions.sh: All references are commented out - build/__functions.sh: Only caller was buildTestBuildImages.sh (removed) Stale/superseded directories: - actions/oryx-dockerfile/: GitHub Action untouched since 2020, references dead MCR image tag (cli-image-3-patch1) and @master (renamed to @main) - monitor_version_scripts/: Superseded by build/tools/Automation/ (.NET tool running via automationTrigger.yaml GH Actions cron). The corresponding ADO pipeline Monitor-versions.yml has been disabled since Oct 2024. - tests/images/build/: 4 Dockerfiles only consumed by the removed buildTestBuildImages.sh and dead __variables.sh entries Other cleanups: - Cleaned dead ORYXTESTS_* variables from build/__variables.sh - Updated Oryx.sln: removed references to non-existent scripts (many were already missing from disk), added generateConstants.sh - Removed doc/buildpack.md (7-year-old WIP stub with no real content)
Third-pass cleanup fixing broken references left after file removals: - build/__variables.sh: remove 15 stale Dockerfile path variables and ACR image names pointing to non-existent files (Dockerfile, ltsVersions.Dockerfile, vso.*.Dockerfile, buildScriptGenerator, supportFiles, githubRunners.BuildPackDeps*, lts-versions/vso ACR names) - doc/architecture.md: replace ~80 lines of broken Dockerfile links (ltsVersions.Dockerfile deleted, Dockerfile->full.Dockerfile, stale runtime template references) with pointers to the actual directories - doc/base_images.md: remove broken links to deleted githubRunner Dockerfiles and non-existent buildRunTimeImage.sh - README.md: remove broken buildBuildImages.sh reference - Oryx.sln: remove stale images\build\Dockerfile solution item - .dockerignore: remove stale vsts/ entry - DockerVolume.cs: update comment referencing deleted vsts\scripts\ - platforms/php: remove dead commented-out __phpVersions.sh references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive audit and cleanup of the Oryx repo, removing orphaned files, dead build scripts, stale references, and broken documentation links.
Total: 114 files changed, 7,473 lines removed
Commit 1: Remove orphaned vsts/ pipelines, dead build scripts, and stub workflow
vsts/folder (66 files) no ADO pipelines reference this GitHub repo's vsts/ directory; all ADO pipelines point to the internalAAPT-Antares-OryxADO repobuildBuildImageBases.sh,buildBuildpacksImages.sh.github/workflows/monitor-versions.yaml(superseded byautomationTemplate.yaml)build/generateConstants.sh(required byautomationTemplate.yamlworkflow)Oryx.sln,doc/architecture.md,doc/base_images.mdCommit 2: Second-pass cleanup remove additional dead files and stale code
CodeMaid.config,Detector.sln,CHANGELOG.mdbuildSln.sh,buildTestBuildImages.sh,testBuildScriptGenerator.sh,testIntegration.sh,buildPlatformBinaries.sh__dotNetCoreRunTimeVersions.sh,__dotNetCoreSdkVersions.sh,__phpVersions.sh,__functions.shactions/oryx-dockerfile/(stale since 2020)monitor_version_scripts/(superseded bybuild/tools/Automation/)tests/images/andtests/testRepo.shdoc/buildpack.md,build/release.txtCommit 3: Fix stale references to deleted files
build/__variables.sh: removed 15 unused Dockerfile path variables and 3 stale ACR image names pointing to non-existent filesdoc/architecture.md: replaced ~80 lines of broken Dockerfile links with pointers to actual directoriesdoc/base_images.md: removed broken githubRunner Dockerfile links and deadbuildRunTimeImage.shreferenceREADME.md: removed brokenbuildBuildImages.shreferenceOryx.sln: removed staleimages\build\Dockerfilesolution item.dockerignore: removed stalevsts/entryDockerVolume.cs: updated comment referencing deletedvsts\scripts\platforms/php: removed dead commented-out__phpVersions.shreferencesVerification
Four verification passes were performed. Final pass confirmed:
.mdinternal links resolve to existing filesOryx.slnproject paths and solution items existbuild/__variables.shpath declarations point to existing files