Skip to content

Run slow test suites in parallel #26523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CraigMacomber wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Run slow test suites in parallel #26523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/dds/merge-tree/.mocharc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@
const getFluidTestMochaConfig = require("@fluid-internal/mocha-test-setup/mocharc-common");

const config = getFluidTestMochaConfig(__dirname);
config.parallel = true;
config.jobs = 4;
module.exports = config;
4 changes: 4 additions & 0 deletions packages/test/test-end-to-end-tests/src/test/.mocharc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,8 @@ if (runningAgainstInternalRouterliciousCluster) {

// TODO: ADO#34589: These tests leak memory and sometimes crash on CI. This is a workaround to increase the memory limit.
config["node-option"] = [...config["node-option"], "max-old-space-size=8000"];

config.parallel = true;
config.jobs = 4;
Comment on lines +60 to +61
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling parallel mode for tests that already require the exit flag (line 14) due to cleanup issues may lead to unexpected behavior. The exit flag indicates tests don't clean up properly, which could cause issues when running in parallel workers. Consider testing thoroughly to ensure parallel execution doesn't exacerbate existing cleanup problems or cause test flakiness. In Mocha's parallel mode, each test file runs in a separate worker process, which may help isolate issues but could also mask cleanup problems that would affect subsequent tests in serial execution.

Suggested change
config.parallel = true;
config.jobs = 4;
// Do not enable Mocha parallel mode here: this suite currently requires --exit due to cleanup issues,
// and tests are known to leak memory. Running in parallel could hide or exacerbate these problems.

Copilot uses AI. Check for mistakes.

module.exports = config;
Loading