Bug 618368: [Subcontracting] Move "Create Prod. BOM/Routing" action to Functions group and rename

[ChethanT]

Summary

• Moves the CreatePurchProvProdBOMRtng action on the Item Card page extension from the Purchase Prices and Discounts group (addafter(PurchPriceLists)) to the Functions group (addlast(Functions))
• Renames the action caption from 'Create purchase provision Prod. BOM/Routing' to 'Create Prod. BOM/Routing'
• Updates the tooltip to remove the now-inconsistent "purchase provision" phrasing
• Cleans up the related report caption from 'Create Production BOM, Routing BOM' to 'Create Production BOM, Routing' (removes the redundant "BOM" suffix)

Fixes AB#618368

Test plan

• Open the Item Card for a manufacturing item in a Subcontracting-enabled environment
• Verify the action no longer appears under Purchase Prices and Discounts
• Verify the action appears under Functions with caption Create Prod. BOM/Routing
• Trigger the action and confirm the Create Production BOM/Routing report runs correctly

🤖 Generated with Claude Code

[github-actions]

AL Documentation Audit

Documentation gaps were detected in the following apps:

• Subcontracting: 0% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

[alexei-dobriansky]

Analysis

Correctness.

• pageextension 99001518 "Subc. Item Card" currently puts the CreatePurchProvProdBOMRtng action under addafter(PurchPriceLists), i.e. inside the Purchase Prices and Discounts group on the Item Card. The bug asks to move it to Functions and rename it. The PR splits the existing addafter block, leaves Subcontractor Prices where it belongs, and uses addlast(Functions) for the moved action. Verified that group(Functions) exists on the base Item Card page (<baseapp>\Inventory\Item\ItemCard.Page.al:1338), so addlast(Functions) is a valid anchor.
• The action's OnAction trigger is unchanged — same Rec.SetRecFilter() → BindSubscription → Report.Run(Report::"Subc. Create Prod. Routing", true, true, Rec) → UnbindSubscription sequence. No behavioral change beyond placement and labels.
• The [AI-REPRO] for AB#618368 says the misplaced action is on the Vendor Card. The action does not exist on the Vendor Card — SubcVendorCard.PageExt.al (99001516) does not declare it. It exists only on SubcItemCard.PageExt.al. The PR correctly fixes it where it actually lives.
• Report caption 'Create Production BOM, Routing BOM' → 'Create Production BOM, Routing' is a clean fix of an awkward duplicate ("Routing BOM" is not a BC concept). Not strictly part of AB#618368's ask, but consistent with the rename theme and not risky.

Side effects.

• The action ID and signature are unchanged; partner extensions referencing the action by name keep working — only the parent group changes. Low ISV impact.
• Caption / ToolTip changes flow through XLIFF auto-extraction, so previously translated strings will be marked needs-translation. Acceptable for a UX bugfix in a v29.0 module.

Risk: Low. UI-only change with no logic touched.

Test coverage. None added. Acceptable — BC tests don't cover ribbon group placement, and the underlying Report.Run is unchanged. Manual verification per the PR's test plan is the right validation.

Recommendation: Accept

1. Optional — note in the PR description that the action lives on the Item Card, not the Vendor Card. AB#618368's [AI-REPRO] says "Open a Vendor Card" but the action is only declared in SubcItemCard.PageExt.al. Calling this out helps the next reader who tries to reproduce against the work item.
2. Optional — mention the report caption tweak in the bug update. The 'Create Production BOM, Routing BOM' → 'Create Production BOM, Routing' rename is a sensible piggy-back, but it goes beyond AB#618368's scope. Either flag it in the PR body or open a tiny follow-up bug for traceability.

No blockers.