Skip to content

[Agent] AI Test Toolkit code review from 28.x backport#7854

Open
qutreson wants to merge 1 commit intomainfrom
bugs/tfs/623338-backport-cr
Open

[Agent] AI Test Toolkit code review from 28.x backport#7854
qutreson wants to merge 1 commit intomainfrom
bugs/tfs/623338-backport-cr

Conversation

@qutreson
Copy link
Copy Markdown
Contributor

@qutreson qutreson commented Apr 26, 2026

Summary

Porting code review comments from #7354

Work Item(s)

Fixes AB#623338

@qutreson qutreson requested a review from a team as a code owner April 26, 2026 06:33
Copilot AI review requested due to automatic review settings April 26, 2026 06:33
@github-actions github-actions Bot added this to the Version 29.0 milestone Apr 26, 2026
@qutreson qutreson enabled auto-merge (squash) April 26, 2026 06:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports previously identified review fixes from #7354 into the 28.x backport stream for the AI Test Toolkit, mainly addressing UI text accuracy and small AL correctness issues.

Changes:

  • Updated “Execution” tooltips to match the actual execution ratio calculation (includes skipped evals in the total).
  • Fixed missing statement terminators (;) in Copilot credit limit page/codeunit.
  • Corrected Copilot credit consumption UI behavior by resetting company-loaded totals and drilling down to the consumption overview.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Tools/AI Test Toolkit/src/TestSuite/AITTestSuite.Page.al Adjusts “Execution” tooltip text to reflect correct ratio definition.
src/Tools/AI Test Toolkit/src/TestSuite/AITTestMethodLines.Page.al Adjusts “Execution” tooltip text to reflect correct ratio definition.
src/Tools/AI Test Toolkit/src/Limits/CopilotCredits/AITEvalMonthlyCopilotCred.Page.al Fixes missing semicolon; resets company-loaded consumption total when reloading buffer data.
src/Tools/AI Test Toolkit/src/Limits/CopilotCredits/AITEvalMonthlyCopilotCred.Codeunit.al Fixes missing semicolon in notification handler wrapper.
src/Tools/AI Test Toolkit/src/Agent/AgentRunHistory.PageExt.al Updates drilldown to open consumption overview for tag-based agent task IDs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL Documentation Audit

Documentation gaps were detected in the following apps:

  • AI-Test-Toolkit: 0% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants