28.0 - Migrate File Storage Connector#7852
Open
aholstrup1 wants to merge 1 commit intoreleases/28.0from
Open
Conversation
…ests Removes the app and its associated test app from the repository. App ID: 79447b11-8301-4d02-a546-2261eb811296 Test App ID: 80ef626f-e8de-4050-b144-0e3d4993a718
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to remove the External File Storage – Azure File Service (Azure File Share) Connector app and its associated test app from the W1 apps set as part of the referenced “migration” work.
Changes:
- Deleted the Azure File Share connector implementation (connector registration, account table/pages, auth enum, and connector codeunit).
- Deleted related permissions/entitlement objects for the connector.
- Deleted the dedicated test app (tests, mocks, and test app manifest).
Reviewed changes
Copilot reviewed 17 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Apps/W1/External File Storage - Azure File Service Connector/Test/src/mocks/ExtFileAccountMock.Codeunit.al | Removed mock used by the connector test suite. |
| src/Apps/W1/External File Storage - Azure File Service Connector/Test/src/ExtAzureFileServiceTest.Codeunit.al | Removed File Share connector tests. |
| src/Apps/W1/External File Storage - Azure File Service Connector/Test/app.json | Removed test app manifest and dependencies. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareConnectorImpl.Codeunit.al | Removed the connector implementation (file/folder operations + account handling). |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareConnector.EnumExt.al | Removed enum extension that registered the connector in “Ext. File Storage Connector”. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAuthType.Enum.al | Removed auth type enum used by the connector account. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAccountWizard.Page.al | Removed account registration wizard page. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAccount.Table.al | Removed connector account table and isolated storage secret handling. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAccount.Page.al | Removed account card page. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/permissions/FileStorageEditExtFileShare.PermissionSetExt.al | Removed permission set extension wiring connector permissions into base sets. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/permissions/FileStorageAdminExtFileShare.PermissionSetExt.al | Removed permission set extension wiring connector permissions into base sets. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/permissions/ExtFileShareRead.PermissionSet.al | Removed connector read permission set. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/permissions/ExtFileShareObjects.PermissionSet.al | Removed connector objects permission set. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/permissions/ExtFileShareEdit.PermissionSet.al | Removed connector edit permission set. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/app.json | Removed main connector app manifest. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/README.md | Removed connector README. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/Entitlements/ExtFileShareConnector.Entitlement.al | Removed implicit entitlement definition. |
Comments suppressed due to low confidence (1)
src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareConnectorImpl.Codeunit.al:1
- This PR deletes the entire Azure File Service/File Share connector implementation and registration. I couldn’t find any new/renamed replacement connector elsewhere in the repo after these deletions, so this looks like a functional removal rather than a migration. If the intent is a migration, please include the new location/objects in the PR or update the PR description to clarify that File Share support is being dropped in 28.0 (and confirm upgrade/compat implications).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#632420