-
Notifications
You must be signed in to change notification settings - Fork 195
Download only relevant project dependencies #2221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spetersenms
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
spetersenms:downloadOnlyRelevantProjectDependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6f19a6d
Compute and use pattern to download only needed project dependencies …
spetersenms 713a918
Merge branch 'main' into downloadOnlyRelevantProjectDependencies
spetersenms 3b4feb1
Inline script moved to separate file.
spetersenms a68ae85
Put branch name logic in AL-Go helper
spetersenms 28c2a63
Using -recurse
spetersenms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
Actions/DownloadProjectDependencies/ComputeDependencyArtifactPattern.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0 | ||
|
|
||
| . (Join-Path $PSScriptRoot "../AL-Go-Helper.ps1" -Resolve) | ||
| Import-Module (Join-Path $PSScriptRoot "DownloadProjectDependencies.psm1" -Resolve) -Force -DisableNameChecking | ||
|
|
||
| $projectDependencies = $ENV:_projectDependenciesJson | ConvertFrom-Json | ConvertTo-HashTable -recurse | ||
| $pattern = Get-DependencyArtifactPattern -Project $ENV:_project -ProjectDependencies $projectDependencies | ||
|
|
||
| if ($pattern) { | ||
| Write-Host "Dependency artifact pattern: $pattern" | ||
| Add-Content -Encoding UTF8 -Path $env:GITHUB_OUTPUT -Value "hasPattern=true" | ||
| Add-Content -Encoding UTF8 -Path $env:GITHUB_OUTPUT -Value "pattern=$pattern" | ||
| } | ||
| else { | ||
| Write-Host "No dependency projects found, skipping artifact download" | ||
| Add-Content -Encoding UTF8 -Path $env:GITHUB_OUTPUT -Value "hasPattern=false" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,9 +29,20 @@ outputs: | |
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Download artifacts from current build | ||
| - name: Compute dependency artifact pattern | ||
| id: computePattern | ||
| shell: ${{ inputs.shell }} | ||
| env: | ||
| _project: ${{ inputs.project }} | ||
| _projectDependenciesJson: ${{ inputs.projectDependenciesJson }} | ||
| run: | | ||
| ${{ github.action_path }}/ComputeDependencyArtifactPattern.ps1 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider wrapping in Invoke-AlGoAction |
||
| - name: Download dependency artifacts from current build | ||
| if: steps.computePattern.outputs.hasPattern == 'true' | ||
| uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| pattern: ${{ steps.computePattern.outputs.pattern }} | ||
| path: ${{ github.workspace }}/.dependencies | ||
|
|
||
| - name: Download project dependencies | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.