Skip to content

Support for Keycloak v17+ in AuthorizationServer::infer#1107

Open
adamkobor wants to merge 1 commit intomicronaut-projects:5.0.xfrom
adamkobor:fix/auth-server-infer-keycloak
Open

Support for Keycloak v17+ in AuthorizationServer::infer#1107
adamkobor wants to merge 1 commit intomicronaut-projects:5.0.xfrom
adamkobor:fix/auth-server-infer-keycloak

Conversation

@adamkobor
Copy link
Copy Markdown

Keycloak 17+ doesn't have the /auth/ fragment in its pre-set URLs, therefore the original logic in AuthorizationServer is outdated, and it's not possible to infer the right type of newer Keycloak instances based on the URL of the issuer. The biggest consequence of this is that EndSessionEndpointResolver is not able to register the right end session endpoint for Keycloak.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 4, 2022

CLA assistant check
All committers have signed the CLA.

@graemerocher graemerocher requested a review from sdelamo October 4, 2022 12:40
@adamkobor
Copy link
Copy Markdown
Author

@sdelamo could you let the GitHub Actions run, please? In this case I could see if the build pass, at least, and fix the necessary stuff until the review starts. Thanks 🙏

@sdelamo
Copy link
Copy Markdown
Contributor

sdelamo commented Oct 13, 2022

I will check this pr soon.

@adamkobor
Copy link
Copy Markdown
Author

Just a side note: this one alone won't solve the issue with Keycloak and RP initiated logouts, #1049 should solve the latter one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants