fix compilation problems on FreeBSD - #959
Open
Florian-Laluque wants to merge 1 commit into
Open
Conversation
mickael-kerjean
force-pushed
the
master
branch
6 times, most recently
from
August 21, 2026 04:51
5dd485d to
6a00773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resoves the issue #954
It seems that the libpthread is not needed anymore in the LDFLAGS for plg_image_c/image_png plugin, it breaks at compilation and I had success removing it.
I also had to add freebsd as a target in the compress package.
For info, you still need to set up the CFLAGS env vars to copile on Freebsd. It is need for google's brotli package.
export CGO_CFLAGS="-I/usr/local/include"
export CGO_LDFLAGS="-L/usr/local/lib -L/usr/lib -L/lib"
Tested in freebsd15 and it works. (I also try uploading a png file and the thumbnail is ok)
The changes are made to only target freebsd, this should have no impact.