fix type error

[mmaelicke]

Hi,
me again. I ran into a strange error, when trying to delineate from megabasins 11 or 12.

delineator/delineate.py

Line 381 in 1fe84cb

for basin in basins:

the for loop over the basins suddenly changes to floats, which makes load_gdf fail:

delineator/delineate.py

Line 388 in 1fe84cb

catchments_gdf = load_gdf("catchments", basin, True)

here, I add a quick fix to force the basinback to integer. However, I do not fully understand why this happens in the first place. From my understanding of the code, the content of basins is not influenced by me, when I change the input outlets.
The only two explanations for me are: nobody tried these to megabasins so far, which is unlikely. The other option is that geopandas is causing the problem. I had to upgrade to geopandas version 1.0.1, as the <= 14.2 versions had problems with pygeos, that I could not solve otherwise.

I still think this needs some investigation, what exactly is happening. Maybe you have yet another idea.

[mheberger]

I definitely used the code in megabasins 11 & 12. I'm 99% sure it's from upgrading libraries.

…

On Mon, Oct 28, 2024 at 10:48 PM Mirko Mälicke ***@***.***> wrote: Hi, me again. I ran into a strange error, when trying to delineate from megabasins 11 or 12. https://github.com/mheberger/delineator/blob/1fe84cb2a309e6817baae407f2d93a6e27a56736/delineate.py#L381 the for loop over the basins suddenly changes to floats, which makes load_gdf fail: https://github.com/mheberger/delineator/blob/1fe84cb2a309e6817baae407f2d93a6e27a56736/delineate.py#L388 here, I add a quick fix to force the basinback to integer. However, I do not fully understand why this happens in the first place. From my understanding of the code, the content of basins is not influenced by me, when I change the input outlets. The only two explanations for me are: nobody tried these to megabasins so far, which is unlikely. The other option is that geopandas is causing the problem. I had to upgrade to geopandas version 1.0.1, as the <= 14.2 versions had problems with pygeos, that I could not solve otherwise. I still think this needs some investigation, what exactly is happening. Maybe you have yet another idea. ------------------------------ You can view, comment on, or merge this pull request online at: #11 Commit Summary - ba3ecca <ba3ecca> fix type error File Changes (1 file <https://github.com/mheberger/delineator/pull/11/files>) - *M* delineate.py <https://github.com/mheberger/delineator/pull/11/files#diff-333e4197fe2a73eb000b39afadecb878627a095c516585e96088d9a7a88202f1> (4) Patch Links: - https://github.com/mheberger/delineator/pull/11.patch - https://github.com/mheberger/delineator/pull/11.diff — Reply to this email directly, view it on GitHub <#11>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADYEMR3JBOSM6XOSM4MOEFTZ54OTTAVCNFSM6AAAAABQZBTVO6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDAMRQGYYDKNY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>