✨ Quality: Fix snippet_output validation when execution is disabled#871
Open
hieuit095 wants to merge 2 commits intomfontanini:masterfrom
Open
Conversation
…is disabled The `snippet_output` comment handler validates that the referenced snippet ID exists. However, when execution is disabled (no `-x` flag), code blocks with `+id` attributes still need to register their IDs so they can be referenced by `<!-- snippet_output: foo -->`. The issue is that the ID registration might be skipped or validated too early when execution is disabled. Affected files: snippet.rs, mod.rs Signed-off-by: hieuit095 <[email protected]>
…is disabled The `snippet_output` comment handler validates that the referenced snippet ID exists. However, when execution is disabled (no `-x` flag), code blocks with `+id` attributes still need to register their IDs so they can be referenced by `<!-- snippet_output: foo -->`. The issue is that the ID registration might be skipped or validated too early when execution is disabled. Affected files: snippet.rs, mod.rs Signed-off-by: hieuit095 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
snippet_outputcomment handler validates that the referenced snippet ID exists. However, when execution is disabled (no-xflag), code blocks with+idattributes still need to register their IDs so they can be referenced by<!-- snippet_output: foo -->. The issue is that the ID registration might be skipped or validated too early when execution is disabled.Severity:
highFile:
src/presentation/builder/comment.rsSolution
In the
push_codemethod ofPresentationBuilder(in snippet.rs), when processing a snippet with an ID attribute, the ID should be registered even when execution is disabled. Currently, ifis_execution_allowed()returns false, the ID registration might be skipped or handled differently.Changes
src/presentation/builder/snippet.rs(modified)src/presentation/builder/mod.rs(modified)Testing
Closes #870