Skip to content

Allow passing of locale map in opts to set localisation via formatLocale #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MagusMachinae wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Allow passing of locale map in opts to set localisation via formatLocale #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/cljs/oz/core.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

(defn ^:no-doc embed-vega
([elem doc] (embed-vega elem doc {}))
([elem doc {:as opts :keys [view-callback]}]
([elem doc {:as opts :keys [view-callback locale]}]
(when doc
(let [doc (clj->js doc)
opts (-> opts
Expand All @@ -40,6 +40,8 @@
opts (merge {:renderer :canvas}
;; Have to think about how we want the defaults here to behave
opts)]
(when locale
(. vega formatLocale (clj->js locale)))
(-> (vegaEmbed* elem doc (clj->js opts))
(.then (fn [res]
(when view-callback
Expand Down