Fixes attribute deserialization when using WebComponents | Fixes #292#373
Open
matuzalemsteles wants to merge 3 commits intometal:developfrom
Open
Fixes attribute deserialization when using WebComponents | Fixes #292#373matuzalemsteles wants to merge 3 commits intometal:developfrom
matuzalemsteles wants to merge 3 commits intometal:developfrom
Conversation
…emove the OR in return | Fixes metal#292 NOTE: It is not recommended to use the OR in this case once the deserilization of a boolean false is made, for example, the OR is false and return the value parameter in this case.
Contributor
Author
|
cc @jbalsas |
Contributor
|
depends on #377 |
Contributor
|
@matuzalemsteles what’s that repl-ish thing you used to make those screens? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been looking at issue #292 and I've been noticing that the big problem of using
booleanwhen it isfalse. In return of the function deserializeValue_ we have OR and asretValgets false the return isvalueparameter that contains'false'.Note
There are some use cases that want to pass a
numbervalue tostring, we can force it into the element attribute by passing"'10'", but the deserializeValue_ function receives''10''with two single quotes and breaks theJSON.parse, but the correct way would be to pass'"10"'to do the parser correctly.Please feel free to offer a solution to avoid this.
Current behavior
Expected behavior