Keep element structure if it is already in the correct structure.#707
Open
nvdbleek wants to merge 1 commit intometafizzy:masterfrom
Open
Keep element structure if it is already in the correct structure.#707nvdbleek wants to merge 1 commit intometafizzy:masterfrom
nvdbleek wants to merge 1 commit intometafizzy:masterfrom
Conversation
There are some frameworks that don't like you to move elements around. By allowing the user to create the viewport and slider nodes themselves, the carousel is usable when you use a framework that doesn't allows you to move elements.
Member
|
Thanks for this PR! I'll have to evaluate this over #381 |
kapouer
pushed a commit
to pageboard/flickity
that referenced
this pull request
Apr 16, 2018
There are some frameworks that don't like you to move elements around. By allowing the user to create the viewport and slider nodes themselves, the carousel is usable when you use a framework that doesn't allows you to move elements. This is metafizzy#707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some frameworks that don't like you to move elements around. By allowing the user to create the viewport and slider nodes themselves, the carousel is usable when you use a framework that doesn't allows you to move elements.