Add an option to adjust the vertical drag sensibility#516
Open
titouanmathis wants to merge 3 commits intometafizzy:masterfrom
titouanmathis:master
Open
Add an option to adjust the vertical drag sensibility#516titouanmathis wants to merge 3 commits intometafizzy:masterfrom titouanmathis:master
titouanmathis wants to merge 3 commits intometafizzy:masterfrom
titouanmathis:master
Conversation
Member
|
Thanks for this PR. Dealing with mobile page scrolling and Flickity is tricky. Making scrolling easier in one way makes it more difficult in the other. I'll have to carefully review this implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is often difficult to scroll vertically on a Flickity slider with touch devices. So I changed the
dragTresholdoption into an object to be able to specify anytreshold and have the possibility to adjust the sensibility of thehasDragStartedtest.