Skip to content

add validation for image source#1266

Open
qmjose wants to merge 1 commit intometafizzy:masterfrom
qmjose:master
Open

add validation for image source#1266
qmjose wants to merge 1 commit intometafizzy:masterfrom
qmjose:master

Conversation

@qmjose
Copy link

@qmjose qmjose commented Feb 15, 2023

Check for src attribute being defined before setting it. This will help with <source> tags within <picture> tags to avoid the unnecessary src="null" on <source> tag that is required if the source element's parent is an <audio> and <video> element, but not allowed if the source element's parent is a <picture> element.

<picture>
  <source type="..." data-flickity-lazyload-srcset="...">
  ...
<picture>
<picture>
  <source type="..." srcset="..."  src="null">
<picture>

Based on MDN Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant