Switch remainder of recipe tests over to HF format checkpoints #2871
Draft
adheep04 wants to merge 2 commits intometa-pytorch:mainfrom
Draft
Switch remainder of recipe tests over to HF format checkpoints #2871adheep04 wants to merge 2 commits intometa-pytorch:mainfrom
adheep04 wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2871
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
Completed
New TODO
|
Collaborator
|
Hey! Thanks for the PR. I will review tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changelog
Remaining recipes:
TODO
pytest testspytest tests -m integration_testQuestions/Notes
@krammnic Please let me know if you notice any bugs or errors or have any pointers for me. I should have the remaining recipes done within the next couple days, sorry again the long wait! life's been pretty crazy haha.