Harden Rule 29 duplicate-schema fingerprinting to avoid false positives#740
Draft
Harden Rule 29 duplicate-schema fingerprinting to avoid false positives#740
Conversation
Agent-Logs-Url: https://github.com/meshery/schemas/sessions/3570a193-0d21-4281-9b0e-33a5b1793b46 Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix false positives in duplicate schema fingerprinting for Rule 29
Harden Rule 29 duplicate-schema fingerprinting to avoid false positives
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule 29 was over-collapsing structurally similar schemas by fingerprinting only coarse property/type shape. That caused false duplicate matches when schemas differed in
$reftargets,requiredfields, constraints, or descriptions.Fingerprint normalization
build/lib/duplicate-schema-fingerprint.js$refpathsrequiredarraysdescriptionminLength,maxLength,pattern,minimum,maximum, and related boundsitems,additionalProperties, andallOf/anyOf/oneOfValidator wiring
build/validate-schemas.jsrequiredentriesFocused regression coverage
tests/validate-schemas-duplicate-schema-fingerprint.test.js$refpathsrequiredsets