This repository was archived by the owner on Oct 26, 2018. It is now read-only.
Fix some bugs with my previous pull request#9
Open
caleb wants to merge 5 commits intomenno:masterfrom
caleb:master
Open
Fix some bugs with my previous pull request#9caleb wants to merge 5 commits intomenno:masterfrom caleb:master
caleb wants to merge 5 commits intomenno:masterfrom
caleb:master
Conversation
added 5 commits
December 22, 2010 13:25
SVG files (e.g. for fonts) sometimes use a hash component in their url to load a specific font from a collection of fonts in one svg file. We should treat these hash components like we do query strings, and ignore them when trying to find files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the starts_with? method to start_with?
Stupid bug where I was trying to access a matched group of a matched group from a regex match