Fix bindlines on Python 3.10+ by using collections.abc.Iterable#520
Open
williamhsiao0403 wants to merge 1 commit into
Open
Fix bindlines on Python 3.10+ by using collections.abc.Iterable#520williamhsiao0403 wants to merge 1 commit into
williamhsiao0403 wants to merge 1 commit into
Conversation
Use collections.abc.Iterable when normalizing bindlines arguments, with a fallback to collections.Iterable for older Python versions. This prevents AttributeError on Python 3.10+ where collections.Iterable has been removed, and adds a regression test covering Indicator.bindlines().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
LineIterator.bindlines()on modern Python versions wherecollections.Iterableis no longer available.bindlines()was still checking iterability viacollections.Iterable, which raisesAttributeErroron Python 3.10+ when an indicator callsbindlines().The change mirrors the compatibility pattern already used elsewhere in the codebase: use
collections.abcwhen available, and fall back tocollectionsfor older Python versions.Changes
collections.abc.IterableinLineIterator.bindlines()Indicator.bindlines()Verification
Tested with Python 3.13.1: