Enhancement/rename menu by felixdollack · Pull Request #81 · medialesson/hugo-theme-event

felixdollack · 2025-06-17T04:45:23Z

Addresses #39 by adding a new partial that checks

(lower .Name) and .Location are not the same
.Name is not empty

Uses .Name if it differs from .Location, otherwise use default string from translation.

Note: The change does not affect the sponsors page as there are two headings.

Checklist

…rwrite title with user input

Copilot

Pull request overview

This PR implements issue #39 by allowing menu entries to be renamed via the Hugo menu configuration name property (instead of requiring translation overrides), and reuses that labeling for certain page headings.

Changes:

Add a menus/menu_label.html partial intended to choose between a menu entry name and a translated default for page headings.
Update header/sidebar/footer/secondary menu rendering to prefer .Name over T "menu.<identifier>".
Update the menu configuration guide to document the new precedence and provide examples.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
layouts/speakers/list.html	Uses new `menu_label` partial for the Speakers page heading.
layouts/sessions/list.html	Uses new `menu_label` partial for the Sessions page heading.
layouts/miscellaneous/location.html	Uses new `menu_label` partial for the Location page heading.
layouts/miscellaneous/about.html	Uses new `menu_label` partial for the About page heading.
layouts/partials/menus/menu_label.html	New partial that tries to derive a heading label from the main menu entry.
layouts/partials/menus/header.html	Changes menu label precedence to prefer `.Name` over translation.
layouts/partials/menus/sidebar.html	Changes menu label precedence to prefer `.Name` over translation (and keeps an aria-label expression).
layouts/partials/menus/footer.html	Changes menu label precedence to prefer `.Name` over translation (and keeps an aria-label expression).
layouts/partials/menus/secondary.html	Changes secondary menu label precedence to prefer `.Name` over translation.
docs/guides/menu-configuration.md	Documents the new name-vs-translation precedence and adds sample `name` usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T16:33:39Z

layouts/partials/menus/header.html

                    class="header-menu__link"
                {{- end }}>
-                {{- or (T (printf "menu.%s" .Identifier)) .Name | safeHTML }}
+                {{- or .Name (T (printf "menu.%s" .Identifier)) | safeHTML }}


Preferring .Name over the menu.<identifier> translation will break the default localization when menus are generated automatically (e.g. via sectionPagesMenu: main from the docs), since Hugo will populate .Name from the page/section title even if the user didn’t explicitly configure a name. Consider only preferring .Name when it’s explicitly set by the user (or when it differs from the default/identifier), otherwise fall back to the translation first.

Suggested change

{{- or .Name (T (printf "menu.%s" .Identifier)) | safeHTML }}

{{- $i18nKey := printf "menu.%s" .Identifier -}}

{{- $i18nLabel := T $i18nKey -}}

{{- if ne $i18nLabel $i18nKey -}}

{{ $i18nLabel | safeHTML }}

{{- else if .Name -}}

{{ .Name | safeHTML }}

{{- else -}}

{{ .Identifier | safeHTML }}

{{- end }}

Copilot · 2026-02-20T16:33:40Z

layouts/partials/menus/menu_label.html

+
+{{- range .menus }}
+  {{- if eq .PageRef $pageRef }}
+    {{ if ne (lower .Name) .Identifier }}
+        {{- or .Name (T $translationKey) }}
+    {{ else }}
+        {{- or (T $translationKey) .Name }}
+    {{ end }}
+    {{- break }}
+  {{- end }}
+{{- end }}


menu_label.html renders nothing if .Site.Menus.main is empty or if no menu item matches the given pageRef, which will make page headings blank (previously these headings always rendered via T <key>). Add a default fallback to the translation (e.g., initialize to T $translationKey and override only when a matching menu item is found).

Suggested change

{{- range .menus }}

{{- if eq .PageRef $pageRef }}

{{ if ne (lower .Name) .Identifier }}

{{- or .Name (T $translationKey) }}

{{ else }}

{{- or (T $translationKey) .Name }}

{{ end }}

{{- break }}

{{- end }}

{{- end }}

{{- $label := T $translationKey -}}

{{- range .menus }}

{{- if eq .PageRef $pageRef }}

{{- if ne (lower .Name) .Identifier }}

{{- $label = or .Name (T $translationKey) -}}

{{- else }}

{{- $label = or (T $translationKey) .Name -}}

{{- end }}

{{- break }}

{{- end }}

{{- end }}

{{- $label -}}

Copilot · 2026-02-20T16:33:40Z

docs/guides/menu-configuration.md

+(e.g. an imprint). When the menus get rendered, user defined name properties will
+take presedence over predefined translations. If the name is empty or not set by


Typo: "presedence" should be "precedence" (and consider hyphenating "user-defined").

Suggested change

(e.g. an imprint). When the menus get rendered, user defined name properties will

take presedence over predefined translations. If the name is empty or not set by

(e.g. an imprint). When the menus get rendered, user-defined name properties will

take precedence over predefined translations. If the name is empty or not set by

Copilot · 2026-02-20T16:33:40Z

layouts/partials/menus/menu_label.html

+{{- range .menus }}
+  {{- if eq .PageRef $pageRef }}
+    {{ if ne (lower .Name) .Identifier }}
+        {{- or .Name (T $translationKey) }}
+    {{ else }}
+        {{- or (T $translationKey) .Name }}
+    {{ end }}
+    {{- break }}
+  {{- end }}
+{{- end }}


There are Playwright tests for menu rendering (e.g. tests/secondary-menu.spec.ts), but this change introduces new behavior (name override vs translation, and headings derived from menu config) without coverage. Add/update tests to assert: (1) default menus still render translated labels, and (2) setting name in menu config overrides the translation for that entry.

Copilot · 2026-02-20T16:33:41Z

layouts/partials/menus/sidebar.html

                {{- end }}
                aria-label="{{- or (T (printf " menu.%s" .Identifier)) .Name }}">
-                {{- or (T (printf "menu.%s" .Identifier)) .Name | safeHTML }}
+                {{- or .Name (T (printf "menu.%s" .Identifier)) | safeHTML }}


Like the header menu, this now prefers .Name over the menu.<identifier> translation. With automatically generated menus (e.g. sectionPagesMenu: main), .Name is populated from page/section titles even when the user didn’t explicitly set name, which can break localization. Consider using the translation by default and only using .Name as an override when explicitly configured / when it differs from the default identifier.

Copilot · 2026-02-20T16:33:41Z

layouts/partials/menus/footer.html

        <li>
            <a class="footer-menu__link" href="{{ .URL }}" aria-label="{{- or (T (printf "menu.%s" .Identifier)) .Name }}">
-                {{- or (T (printf "menu.%s" .Identifier)) .Name }}
+                {{- or .Name (T (printf "menu.%s" .Identifier)) }}


This now prefers .Name over the menu.<identifier> translation. If menu items are generated automatically (e.g. via sectionPagesMenu), .Name will be set even without a user-configured name, which can bypass translations and break localization. Consider using the translation by default and only using .Name when it’s explicitly configured / differs from the default.

Suggested change

{{- or .Name (T (printf "menu.%s" .Identifier)) }}

{{- or (T (printf "menu.%s" .Identifier)) .Name }}

Copilot · 2026-02-20T16:33:41Z

layouts/partials/menus/sidebar.html

@@ -13,7 +13,7 @@
                    class="sidebar-menu__link"
                {{- end }}
                aria-label="{{- or (T (printf " menu.%s" .Identifier)) .Name }}">


aria-label still prefers the translation key (and includes a leading space in printf " menu.%s"), while the visible link text now prefers .Name. This can cause assistive tech to announce a different label than what’s displayed, and the leading space will also break the i18n lookup. Update aria-label to use the same label expression as the link text, and remove the leading space in the translation key format string.

Suggested change

aria-label="{{- or (T (printf " menu.%s" .Identifier)) .Name }}">

aria-label="{{- or .Name (T (printf "menu.%s" .Identifier)) }}">

Copilot · 2026-02-20T16:33:41Z

layouts/partials/menus/footer.html

            <a class="footer-menu__link" href="{{ .URL }}" aria-label="{{- or (T (printf "menu.%s" .Identifier)) .Name }}">
-                {{- or (T (printf "menu.%s" .Identifier)) .Name }}
+                {{- or .Name (T (printf "menu.%s" .Identifier)) }}


The link text now prefers .Name, but aria-label still prefers the translation. This can produce a mismatch between visible text and the accessible name. Make aria-label follow the same precedence as the rendered label (or derive it from the same $title variable).

felixdollack added 4 commits June 17, 2025 13:23

Prefer .Name over .Identifier in menus

b9b92e4

Add partial to check if name is user generated

a17d403

Use menu partial in about, location, session and speakers page to ove…

90274ea

…rwrite title with user input

Update menu docs

3aaa161

ThomasPe requested a review from Copilot February 20, 2026 16:25

Copilot started reviewing on behalf of ThomasPe February 20, 2026 16:26 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Enhancement/rename menu#81

Enhancement/rename menu#81
felixdollack wants to merge 4 commits intomedialesson:mainfrom
face-and-gesture-2026:enhancement/rename_menu

felixdollack commented Jun 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-                {{- or .Name (T (printf "menu.%s" .Identifier)) | safeHTML }}
+                {{- $i18nKey := printf "menu.%s" .Identifier -}}
+                {{- $i18nLabel := T $i18nKey -}}
+                {{- if ne $i18nLabel $i18nKey -}}
+                    {{ $i18nLabel | safeHTML }}
+                {{- else if .Name -}}
+                    {{ .Name | safeHTML }}
+                {{- else -}}
+                    {{ .Identifier | safeHTML }}
+                {{- end }}

		(e.g. an imprint). When the menus get rendered, user defined name properties will
		take presedence over predefined translations. If the name is empty or not set by

	{{- or .Name (T (printf "menu.%s" .Identifier)) }}
	{{- or (T (printf "menu.%s" .Identifier)) .Name }}

	aria-label="{{- or (T (printf " menu.%s" .Identifier)) .Name }}">
	aria-label="{{- or .Name (T (printf "menu.%s" .Identifier)) }}">

Comments

Conversation

felixdollack commented Jun 17, 2025

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant