fixed missing type information on related models #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Additionally I added a '?' to optional class properties in order to support this feature introduced with TypeScript 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request are you creating?
How many unit test did you write for this pull request?
zero. small fix that runs without any problems on my big project.
Please add a description for your pull request:
Issue
Related models will not be typed (i.e. get the type
anyorany[]) if they do not appear in a scope method (like `__get__related_model"). This leads to a lot of missing type information if you have a clean rest api, where you only expose a few remote methods but not the whole bunch of methods exposed by default.Solution
This Pull Request adds the type information about the related model to the model description.