Reconcile Element and KeyframeEffect iterationComposite data#29386
Open
Reconcile Element and KeyframeEffect iterationComposite data#29386
Element and KeyframeEffect iterationComposite data#29386Conversation
github-actions
bot
added
the
data:api
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Test-case: https://wpt.fyi/results/web-animations/interfaces/KeyframeEffect/iterationComposite.html?label=master&label=stable&aligned&q=iterationComposite Issue: web-platform-dx/web-features#3907 Issue: mdn#18963 Co-authored-by: Patrick Brosset <[email protected]>
ddbeck
force-pushed
the
iteration-composite-3907
branch
from
1b00b39 to
da1f5cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safari supports
iterationCompositein both ways you can set it. It wasn't updated in both places though, when it shipped.Test results and supporting details
Caught by @captainbrosset in web-platform-dx/web-features#3907 (review).
I think this was not caught in the review of #18963.
Test: https://wpt.fyi/results/web-animations/interfaces/KeyframeEffect/iterationComposite.html?label=master&label=stable&aligned&q=iterationComposite
Related issues
iterationCompositefeature web-platform-dx/web-features#3907