Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
|
Thanks @caugner - I accepted all. |
|
Update: this was just released in Safari 26.4! https://webkit.org/blog/17862/webkit-features-for-safari-26-4/ |
| }, | ||
| "container_query_optional": { | ||
| "__compat": { | ||
| "description": "name-only container queries", |
There was a problem hiding this comment.
The previous version of the description was consistent with prior art, see this GitHub search.
| "description": "name-only container queries", | |
| "description": "`<container-query>` is optional", |
There was a problem hiding this comment.
@caugner The easy option would be for me to just accept this and get it in. But discussions like #29217 (comment) imply that we should try to reflect the consequences of the change.
In this case the consequence of making container query optional is that you can now have a container query that just filters on the name. That is the reason for this change and the main impact.
If you disagree, then please accept your changes and merge. If you agree, please just merge.
| } | ||
| } | ||
| }, | ||
| "container_query_optional": { |
There was a problem hiding this comment.
| "container_query_optional": { | |
| "container-query_optional": { |
Co-authored-by: Claas Augner <[email protected]>
17a8d54 to
045a915
Compare
| "spec_url": "https://drafts.csswg.org/css-conditional-5/#typedef-container-condition", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "preview", |
There was a problem hiding this comment.
It is expected to be merged into Chrome 148
https://chromium-review.googlesource.com/c/chromium/src/+/7705690
FF149 adds support for
@containerselections where the<container-query>part is optiona in https://bugzilla.mozilla.org/show_bug.cgi?id=2016474This allows you to just select a container based on its name:
@container --name {}This adds the subfeature. You can test this using https://wpt.live/css/css-conditional/container-queries/query-container-name.html
Note that I have set Chrome and Safari as
falsebut you can tell it is coming because they pass the test on the latest versions but NOT on current versions I can access: https://wpt.fyi/results/css/css-conditional/container-queries/query-container-name.html?label=master&label=experimental&alignedRelated docs work can be tracked in mdn/content#43212